Pro 6822 color picker broken #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
commented
Nov 20, 2024
| max-height: 999px; | ||
| padding: $spacing-base 0; |
There was a problem hiding this comment.
Remove the padding here to add it above to .apos-schema it allows the animation of the dropdown to not jump (padding still being here when finishing to close the dropdown).
It's more pleasing to the eye.
ValJed
commented
Nov 20, 2024
| @@ -265,6 +263,7 @@ | |||
|
|
|||
| &.collapse-enter-active, | |||
| &.collapse-leave-active { | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
We only need the overflow hidden during the animation. This way it's not the case when opened and the color picker can overflow.
ValJed
commented
Nov 20, 2024
| @@ -115,7 +115,7 @@ export default { | |||
| Saturation: saturation, | |||
| Hue: hue, | |||
| Alpha: alpha, | |||
| EdIn: editableInput, | |||
| EditableContent: editableInput, | |||
There was a problem hiding this comment.
Just making in more readable
ValJed
commented
Nov 20, 2024
| @@ -124,6 +124,7 @@ export default { | |||
| } | |||
|
|
|||
| .apos-color__input { | |||
| width: 100%; | |||
There was a problem hiding this comment.
Fixes the rgba inputs not wanting to respect the flexed parent size
stuartromanek
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRO-6822
Summary
What are the specific steps to test this change?
Color picker is not hidden by a overflow hidden in inline array
Color picker doesn't have input going off the modal
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: