Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement vue-color in Apostrophe #4803

Merged
merged 17 commits into from
Nov 14, 2024
Merged

implement vue-color in Apostrophe #4803

merged 17 commits into from
Nov 14, 2024

Conversation

stuartromanek
Copy link
Member

@stuartromanek stuartromanek commented Nov 12, 2024

Summary

  • Removes the vue-color dependency
  • Implements vue-color component directly in Apostrophe
  • Swap tinycolor2 for @ctrl/tinycolor and update usage accordingly

Note: This is a straight port. No API surfaces changed or additional features implemented.

✅ UI Tests passed here https://github.com/apostrophecms/testbed/actions/runs/11784024947

Related PRs
https://github.com/apostrophecms/testbed/pull/309

What are the specific steps to test this change?

  1. npm run dev
  2. Check a schema color field
  3. Check the rich text color tool

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@stuartromanek stuartromanek marked this pull request as draft November 12, 2024 18:25
@stuartromanek stuartromanek marked this pull request as ready for review November 12, 2024 20:50
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're copying in a bunch of code here, we need to add a section to our LICENSE.md. After the existing material:

"Portions derived from vue-color require the following statement:"

And then the contents of the license file from vue-color, which is also MIT license (so fully compatible).

@stuartromanek
Copy link
Member Author

@boutell [Like this]? (6b2c03a) No additional formatting?

Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@stuartromanek stuartromanek merged commit 96eac29 into main Nov 14, 2024
9 checks passed
@stuartromanek stuartromanek deleted the import-colorpicker branch November 14, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants