-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement vue-color in Apostrophe #4803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're copying in a bunch of code here, we need to add a section to our LICENSE.md
. After the existing material:
"Portions derived from vue-color require the following statement:"
And then the contents of the license file from vue-color, which is also MIT license (so fully compatible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Summary
vue-color
dependencyvue-color
component directly in Apostrophetinycolor2
for@ctrl/tinycolor
and update usage accordinglyNote: This is a straight port. No API surfaces changed or additional features implemented.
✅ UI Tests passed here https://github.com/apostrophecms/testbed/actions/runs/11784024947
Related PRs
https://github.com/apostrophecms/testbed/pull/309
What are the specific steps to test this change?
color
toolWhat kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: