handle validate for choices #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
approved these changes
Nov 4, 2024
ValJed
requested changes
Nov 5, 2024
| @@ -656,6 +673,9 @@ module.exports = { | |||
| continue; | |||
| } | |||
| } | |||
| if (isParentVisible === false) { | |||
| continue; | |||
| } | |||
There was a problem hiding this comment.
@boutell Would like your opinion on that:
In this file just before line 672 we add default value to hidden fields.
If this is necessary, I suppose that we should do the same thing when a parent is hidden?
WDYT?
boutell
requested changes
Nov 5, 2024
* main: fix vue warnings (#4797) Pro 6694 breakpoint preview vite ready (#4789) Resolve yaml dependency conflicts (#4801) PRO-6775: External frontend support, docs cleanup (#4799) sort glob result (#4796) HMR condition argument and widget player fix (#4794) fix permission grid tooltip display (#4792) Fix extra bundle detection (#4791) release 4.9.0 (#4788) Pro 6535 revision (#4787)
boutell
previously approved these changes
Nov 11, 2024
* main: fixes modals deep selectors (#4795)
ValJed
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Log only errors for visible fields + wait for choices to trigger validate
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: