Pro 6694 breakpoint preview vite ready #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroun
reviewed
Nov 4, 2024
haroun
reviewed
Nov 4, 2024
haroun
requested changes
Nov 4, 2024
ValJed
force-pushed
the
pro-6694-breakpoint-preview-vite-ready
branch
from
913fd5a to
f5186f1
Compare
myovchev
requested changes
Nov 7, 2024
ValJed
force-pushed
the
pro-6694-breakpoint-preview-vite-ready
branch
from
71294ed to
a258ef6
Compare
ETLaurent
previously approved these changes
Nov 7, 2024
| sourcemaps: self.options.productionSourceMaps | ||
| sourcemaps: self.options.productionSourceMaps, | ||
| postcssViewportToContainerToggle: { | ||
| enable: self.options.breakpointPreviewMode?.enable, |
There was a problem hiding this comment.
Suggested change
| enable: self.options.breakpointPreviewMode?.enable, | |
| enable: self.options.breakpointPreviewMode?.enable === true, |
like below?
haroun
previously approved these changes
Nov 7, 2024
myovchev
previously approved these changes
Nov 8, 2024
ValJed
force-pushed
the
pro-6694-breakpoint-preview-vite-ready
branch
from
e34bd09 to
996d5bf
Compare
myovchev
approved these changes
Nov 11, 2024
haroun
added a commit
that referenced
this pull request
Nov 11, 2024
* main: fix vue warnings (#4797) Pro 6694 breakpoint preview vite ready (#4789) Resolve yaml dependency conflicts (#4801) PRO-6775: External frontend support, docs cleanup (#4799) sort glob result (#4796) HMR condition argument and widget player fix (#4794) fix permission grid tooltip display (#4792) Fix extra bundle detection (#4791) release 4.9.0 (#4788) Pro 6535 revision (#4787)
haroun
added a commit
that referenced
this pull request
Nov 12, 2024
* main: changelog (#4802) fixes modals deep selectors (#4795) fix vue warnings (#4797) Pro 6694 breakpoint preview vite ready (#4789) Resolve yaml dependency conflicts (#4801) PRO-6775: External frontend support, docs cleanup (#4799) sort glob result (#4796) HMR condition argument and widget player fix (#4794) fix permission grid tooltip display (#4792) Fix extra bundle detection (#4791) release 4.9.0 (#4788) Pro 6535 revision (#4787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRO-6694
Summary
Uses new externalize postcss plugin instead of having one postcss plugin and one webpack loader.
Cypress tests running HERE 🟢
What are the specific steps to test this change?
Should be tested with this new plugin:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: