Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation #4292

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Italian translation #4292

merged 3 commits into from
Sep 18, 2023

Conversation

Tonel
Copy link
Contributor

@Tonel Tonel commented Sep 17, 2023

Summary

Italian translation file (it.json) added.

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Configure it as teh default locale
  3. Navigate the Admin UI and make sure the labels are now in Italian

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Contributor

@BoDonkey BoDonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two requests:

  1. Can you change the version/dateline of the CHANGELOG to "UNRELEASED", please. We add a version number and a date when we publish to npm. Additional changes will likely land before then which may impact the version number.
  2. Can you please eliminate the .idea/workspce.xml file from the commit/PR.

@Tonel
Copy link
Contributor Author

Tonel commented Sep 18, 2023

@BoDonkey Thanks!

  1. CHANGELOG.md updated
  2. .idea folder removed

Copy link
Contributor

@BoDonkey BoDonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@BoDonkey BoDonkey merged commit 83beafd into apostrophecms:main Sep 18, 2023
6 checks passed
@boutell
Copy link
Member

boutell commented Sep 18, 2023 via email

@Tonel
Copy link
Contributor Author

Tonel commented Sep 18, 2023

@boutell You are welcome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants