hotfix for logging non-Error exceptions from api routes #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-4779 Non-Error API route exceptions should not crash structured logging
Right now throwing a string in an API route crashes structured logging, which does not take the application down, but prevents you from seeing the original error. This is blocking Holon debugging. |
boutell
commented
Sep 11, 2023
| it('should fail politely in the weird case of a non-Error exception', async function() { | ||
| let msgWas; | ||
| const consoleError = console.error; | ||
| console.error = msg => { |
There was a problem hiding this comment.
hijack console.error so we can look at the output there to figure out what exactly is being written
gregvanbrug
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix, see changelog
What are the specific steps to test this change?
Tests pass
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: