-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro 4504 inline figure #4281
Pro 4504 inline figure #4281
Conversation
PRO-4504 There is an issue with padding and/or Image and text justification since upgrading to A3.
Utah was upgraded to Apostrophe 3 (by us) and they've been finding some styles that are broken. The two examples he provides are here:
Note: Do not start without a code walkthrough if you are new to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A confirmation prompt is surprising behavior from a command line system task, especially in a production environment, so I would suggest requiring the user to run it again with a --confirm
option.
} | ||
); | ||
|
||
console.log(value, typeof value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray log
* main: release 3.55.0 default value for field._id add field._id to schema field key
I've added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Harouna, I should have been more clear about this:
Our hosted customer CLI currently cannot run an interactive task with a confirmation prompt.
Therefore, we should use a --confirm
option for this, rather than defaulting to a prompt they can't see or respond to, and requiring them to use the scary word --force
to succeed.
Support for interactive tasks is on my to-do list but it may be a while.
* main: fix code overthinking Response to first comments Add note to CHANGELOG expands per area configuration
Summary
Fix inline figure in rich-text + Remove empty paragraph from rich text widget tasks
What are the specific steps to test this change?
node app.js @apostrophecms/rich-text-widget:fix-inline-figure
and confirmnode app.js @apostrophecms/rich-text-widget:remove-empty-paragraph
and confirmWhat kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: