Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro 4504 inline figure #4281

Merged
merged 10 commits into from
Sep 8, 2023
Merged

Pro 4504 inline figure #4281

merged 10 commits into from
Sep 8, 2023

Conversation

haroun
Copy link
Contributor

@haroun haroun commented Aug 30, 2023

Summary

Fix inline figure in rich-text + Remove empty paragraph from rich text widget tasks

What are the specific steps to test this change?

  1. Run the task node app.js @apostrophecms/rich-text-widget:fix-inline-figure and confirm
  2. Run the task node app.js @apostrophecms/rich-text-widget:remove-empty-paragraph and confirm
  3. Integration tests must be green

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@haroun haroun self-assigned this Aug 30, 2023
@linear
Copy link

linear bot commented Aug 30, 2023

PRO-4504 There is an issue with padding and/or Image and text justification since upgrading to A3.

Utah was upgraded to Apostrophe 3 (by us) and they've been finding some styles that are broken. The two examples he provides are here:

Note: Do not start without a code walkthrough if you are new to this project.

@haroun haroun requested a review from boutell August 30, 2023 12:51
@haroun haroun marked this pull request as ready for review August 30, 2023 12:52
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A confirmation prompt is surprising behavior from a command line system task, especially in a production environment, so I would suggest requiring the user to run it again with a --confirm option.

}
);

console.log(value, typeof value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray log

* main:
  release 3.55.0
  default value for field._id
  add field._id to schema field key
@haroun haroun requested a review from boutell September 7, 2023 08:19
@haroun
Copy link
Contributor Author

haroun commented Sep 7, 2023

I've added a --force to skip the prompt.

Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Harouna, I should have been more clear about this:

Our hosted customer CLI currently cannot run an interactive task with a confirmation prompt.

Therefore, we should use a --confirm option for this, rather than defaulting to a prompt they can't see or respond to, and requiring them to use the scary word --force to succeed.

Support for interactive tasks is on my to-do list but it may be a while.

* main:
  fix code overthinking
  Response to first comments
  Add note to CHANGELOG
  expands per area configuration
@haroun haroun requested a review from boutell September 8, 2023 09:20
@haroun haroun merged commit ce7cc93 into main Sep 8, 2023
6 checks passed
@haroun haroun deleted the pro-4504-inline-figure branch September 8, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants