Add additional rtw area config #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
requested changes
Aug 30, 2023
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### Adds | |||
|
|
|||
| * Add `publicApiCheckAsync` wrapper method (and use it internally) to allow for async permission checks of REST APIs. This feature doesn't introduce any breaking changes. | |||
| * Add ability to add custom rich-text-widget options per area. | |||
There was a problem hiding this comment.
Please say just a little more here. I know there will be docs, but how about: add ability for custom tiptap extensions to access the options passed to rich text widgets at the area level?
haroun
requested changes
Sep 5, 2023
| @@ -546,7 +546,8 @@ export default { | |||
| return (apos.tiptapExtensions || []) | |||
| .map(extension => extension({ | |||
| styles: this.editorOptions.styles.map(this.localizeStyle), | |||
| types: this.tiptapTypes | |||
| types: this.tiptapTypes, | |||
There was a problem hiding this comment.
I think you can achieve the same goal with
aposTiptapExtensions() {
return (apos.tiptapExtensions || [])
.map(extension => extension({
...this.editorOptions,
styles: this.editorOptions.styles.map(this.localizeStyle),
types: this.tiptapTypes
}));
},There was a problem hiding this comment.
I guess I overthought that a bit! 😅
haroun
previously approved these changes
Sep 6, 2023
boutell
approved these changes
Sep 7, 2023
| ## 3.55.0 | ||
|
|
||
| ### Adds | ||
|
|
||
| * Add `publicApiCheckAsync` wrapper method (and use it internally) to allow for async permission checks of REST APIs. This feature doesn't introduce any breaking changes. | ||
| * Add ability to add custom rich-text-widget options per area. | ||
| * Add `publicApiCheckAsync` wrapper method (and use it internally) to allow for overrides to do async permission checks of REST APIs. This feature doesn't introduce any breaking changes because the default implementation still invokes `publicApiCheck` in case developers have overridden it. |
There was a problem hiding this comment.
The PR was opened before the last release date so there ended up being a merge conflict in the CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR extends the rich-text-widget to allow for custom options to be passed through the per area configuration. This will allow for new Tiptap extensions to pass their own configuration options. A tutorial on this subject and three new improvements to the rich-text-widget will be released to take advantage of this. This change does not alter the existing configuration behavior.
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: