-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OTel to support Hyper 1 #6493
Open
tninesling
wants to merge
13
commits into
next
Choose a base branch
from
tninesling/otel-0_24
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions compatible with 0.24. Mostly done, pending Jaeger changes.
…pted to switch Jaeger integration tests to use OTLP, and replaced deprecated i64_histogram with u64_histogram.
…nd fixed some tests. Trace integration tests still need updates due to change in span data.
✅ Docs Preview ReadyNo new or changed pages found. |
CI performance tests
|
…now merges resource template attributes into the spans attributes.
…ing resource attributes into all spans.
tninesling
changed the title
[WIP] Upgrade OTel to support Hyper 1
Upgrade OTel to support Hyper 1
Dec 20, 2024
…0_2 gets to stay because it is still used in one test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opentelemetry crate began supporting hyper 1 at version 0.24. At 0.25, the openetelemetry folks started publishing all the related packages in lockstep with the main crate, but they also made some significant breaking changes which will require a large rewrite of our wrappers. I've stuck with 0.24 instead of going all the way to the latest 0.27 to minimize the changes in this particular upgrade.
The main breaking changes are:
u64_histogram
instead.The smaller changes are:
Unit
struct is replaced with opaqueCow<'static, str>
SpanData
no longer contains aResource
, so we need to add that data separately prior to export and implementset_resource
for wrappers onSpanExporter
andSpanProcessor
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩