Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTel to support Hyper 1 #6493

Open
wants to merge 13 commits into
base: next
Choose a base branch
from
Open

Upgrade OTel to support Hyper 1 #6493

wants to merge 13 commits into from

Conversation

tninesling
Copy link
Contributor

@tninesling tninesling commented Dec 19, 2024

The opentelemetry crate began supporting hyper 1 at version 0.24. At 0.25, the openetelemetry folks started publishing all the related packages in lockstep with the main crate, but they also made some significant breaking changes which will require a large rewrite of our wrappers. I've stuck with 0.24 instead of going all the way to the latest 0.27 to minimize the changes in this particular upgrade.

The main breaking changes are:

  • Jaeger tracing support has been totally removed, as it was last supported in opentelemetry 0.23, which didn't support hyper 1. Jaeger traces should use OTLP instead.
  • Histograms no longer support i64 because the spec requires non-negative values. Use u64_histogram instead.

The smaller changes are:

  • The opentelemetry_api crate is replaced with opentelemetry
  • The opentelemetry::sdk module is now in the separate opentelemetry_sdk crate
  • The Unit struct is replaced with opaque Cow<'static, str>
  • SpanData no longer contains a Resource, so we need to add that data separately prior to export and implement set_resource for wrappers on SpanExporter and SpanProcessor

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

…ions compatible with 0.24. Mostly done, pending Jaeger changes.
…pted to switch Jaeger integration tests to use OTLP, and replaced deprecated i64_histogram with u64_histogram.
…nd fixed some tests. Trace integration tests still need updates due to change in span data.
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Dec 19, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Dec 19, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@tninesling tninesling changed the title [WIP] Upgrade OTel to support Hyper 1 Upgrade OTel to support Hyper 1 Dec 20, 2024
@tninesling tninesling marked this pull request as ready for review December 20, 2024 00:35
@tninesling tninesling requested review from a team as code owners December 20, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants