Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement path->withError(message) for inline error reporting #6457

Draft
wants to merge 3 commits into
base: benjamn/JSONSelection-variadic-ExprPath
Choose a base branch
from

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Dec 13, 2024

This PR proposes an implementation of the ->withError method I alluded to in #6456.

@benjamn benjamn self-assigned this Dec 13, 2024
@benjamn benjamn requested a review from a team as a code owner December 13, 2024 21:51
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Dec 13, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Dec 13, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@lennyburdette
Copy link
Contributor

spoke offline: i need to figure out a few general error-related things, so let's move this to draft so we can get the other PRs landed first. 🙏🏻

@benjamn benjamn force-pushed the benjamn/JSONSelection-variadic-ExprPath branch from 909e897 to e5eedde Compare December 16, 2024 18:24
@benjamn benjamn force-pushed the benjamn/JSONSelection-withError-arrow-method branch from 118be8e to ac60d8d Compare December 16, 2024 18:27
@benjamn benjamn marked this pull request as draft December 16, 2024 18:27
@benjamn
Copy link
Member Author

benjamn commented Dec 16, 2024

Converting this PR to draft and moving it out of the branch chain of my other recent PRs.

@benjamn benjamn force-pushed the benjamn/JSONSelection-variadic-ExprPath branch 2 times, most recently from 16d0306 to dfeb558 Compare December 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants