-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement path->withError(message)
for inline error reporting
#6457
Draft
benjamn
wants to merge
3
commits into
benjamn/JSONSelection-variadic-ExprPath
Choose a base branch
from
benjamn/JSONSelection-withError-arrow-method
base: benjamn/JSONSelection-variadic-ExprPath
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement path->withError(message)
for inline error reporting
#6457
benjamn
wants to merge
3
commits into
benjamn/JSONSelection-variadic-ExprPath
from
benjamn/JSONSelection-withError-arrow-method
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
CI performance tests
|
spoke offline: i need to figure out a few general error-related things, so let's move this to draft so we can get the other PRs landed first. 🙏🏻 |
benjamn
force-pushed
the
benjamn/JSONSelection-variadic-ExprPath
branch
from
December 16, 2024 18:24
909e897
to
e5eedde
Compare
benjamn
force-pushed
the
benjamn/JSONSelection-withError-arrow-method
branch
from
December 16, 2024 18:27
118be8e
to
ac60d8d
Compare
Converting this PR to draft and moving it out of the branch chain of my other recent PRs. |
benjamn
force-pushed
the
benjamn/JSONSelection-variadic-ExprPath
branch
2 times, most recently
from
December 16, 2024 19:12
16d0306
to
dfeb558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an implementation of the
->withError
method I alluded to in #6456.