Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: keep Express at v4 #7974

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,22 @@
{
matchPackageNames: ["uuid"],
allowedVersions: "9.x",
},
// We specifically provide a first-party integration (`expressMiddleware`
// imported from `@apollo/server/express4`) for Express v4 because it is the
// most common web framework. (Additionally, as an internal implementation
// detail, it is what powers `startStandaloneServer`, though users of that
// function should not rely on anything other than that it uses standard
// Node `http` request and response objects.) It is easy to build
// integrations for other web servers, including Express v5, which is not
// yet as popular as Express v4. So we don't plan to provide a built-in
// Express v5 implementation any time soon (most likely as part of a new
// major version); we appreciate the simplicity of a build system that only
// installs one version of any given practice. See
// https://github.com/apollographql/apollo-server/issues/7928.
{
matchPackageNames: ["express", "@types/express", "@types/express-serve-static-core"],
allowedVersions: "4.x",
}
]
}