fix: DataDict initialization of deferredFragments
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
AnthonyMDev
approved these changes
Dec 16, 2024
|
|
||
| var deferredFragments: OrderedSet<String> = [] | ||
|
|
||
| let nameGenerator: (_ typeInfo: SelectionSet.TypeInfo) -> String = { typeInfo in |
There was a problem hiding this comment.
Love this pattern. Very clean!
calvincestari
deleted the
fix/data-dict-initializer-deferred-fragments
branch
BobaFetters
pushed a commit
that referenced
this pull request
Dec 16, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Dec 16, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Dec 16, 2024
6db35551 fix: `DataDict` initialization of `deferredFragments` (#557) git-subtree-dir: apollo-ios-codegen git-subtree-split: 6db35551c7bc0879b61539c08338253a7b4a146b
BobaFetters
pushed a commit
that referenced
this pull request
Dec 16, 2024
…of `deferredFragments` git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 9c595a8 git-subtree-split: 6db35551c7bc0879b61539c08338253a7b4a146b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on selection set initializers I realized that the current generated initializers do not set the selection set types in the
deferredFragmentsproperty.Some of the named fragment initializers do not look correct but I believe this is due to apollographql/apollo-ios#3486 and apollographql/apollo-ios#3487. Adding the values to
deferredFragmentwill not have any detrimental effect and those will get fixed on top of this work.