Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @mask directive #11896

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jun 13, 2024

Work in progress

Initial implementation of the @mask directive as discussed here: #11666 (comment).

A potential solution for #11514

Copy link

netlify bot commented Jun 13, 2024

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 28c3e6e

Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: 28c3e6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jerelmiller
Copy link
Member

Hey @vladar 👋 Thanks for the PR!

Just an FYI, I'm still working through the data masking implementation and getting the APIs added to the appropriate spots in the codebase. I've got my in-progress work on the data-masking branch. The changes there may change significantly between now and any public release, so just be aware that anything you add in this PR may require refactoring to work with the changes introduced in that branch. I'd hate for you to spend a bunch of time maintaining this branch as things are still in flux.

Until I'm a little further along in the implementation and determine whether the @mask directive makes sense, I won't be able to accept these changes. For now, feel free to follow along on that branch for the in-progress work.

@vladar
Copy link
Contributor Author

vladar commented Jun 13, 2024

@jerelmiller this is just a playground PR, mostly for you if you want to play with @mask. Great to see progress on data masking in Apollo, thanks for driving it!

@jerelmiller
Copy link
Member

Got it. Appreciate the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants