fix: rewrote utils.parseOpenGraph() so it can parse arrays of objects with properties. #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some more work on the Open Graph parser. Let me know if you need any other changes. |
|
Hello @daball, and thanks for your contribution! Is this ready for review or are you planning to work on it more? If it's not ready, please convert it to draft 🙂 |
I think it's ready. But because I know it's not finished, I will reluctantly go back to draft. And because I don't like that it's not finished. It needs more test cases and it needs me to finish the conversion and also to probably break the API just a little further. And I need a couple more days to finish it. |
daball
changed the title
B4nan
added
the
t-tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Open Graph Parser so that it can parse arrays of images with properties and present them as arrays of image objects with properties. There are other Open Graph meta tags which can also contain arrays of objects with properties, and this update does not address those (e.g. video, etc.), but it provides a template which works more specifically than the simpler code which is still featured. This update is neither fully generalized nor fully specialized but presents another way to do it. This new code still passes the old tests and the new test, but I can imagine many other test cases which will still fail without additional work on this module. As long as everyone is okay with this approach I can work on it further.