feat: add "ACTOR_" env vars #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-platform
fnesveda
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Yeah, the naming will always be a mess here, I'm afraid. I think having a second dict is the best choice, and I would move the ACTOR_MAX_PAID_DATASET_ITEMS there (cc @mhamas).
Not sure how we'll deal with this on the SDK side though, consuming and merging these env vars will be a pain.
|
sounds good to me, just please work closely with delivery and tooling team so that actors are not broken. |
drobnikj
approved these changes
Jun 29, 2023
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stuff to discuss:
ACTOR_ENV_VARSor should it just be placed insideENV_VARSwith some weird prefix? (since there are already variables likeACTOR_RUN_IDwhich points toAPIFY_ACTOR_RUN_ID)ACTOR_MAX_PAID_DATASET_ITEMSis in the originalENV_VARSdict and it's the only one not prefixed withAPIFY_, which is quite inconsistent. Should it be moved/duplicated? (and it's also missing from the actor spec)