feat!: Removing unused ACTOR_BASE_DOCKER_IMAGES and ACTOR_BASE_DOCKER_IMAGE_DEFAULT constants #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant is not currently used anywhere, and the repo with docker images should serve as a single source of truth.
mtrunkat
added
adhoc
github-actions
bot
added
the
t-platform
fnesveda
requested changes
Apr 11, 2023
packages/consts/src/consts.ts
Outdated
| * Default image from ACTOR_BASE_DOCKER_IMAGES. | ||
| */ | ||
| export const ACTOR_BASE_DOCKER_IMAGE_DEFAULT = ACTOR_BASE_DOCKER_IMAGES[0].name; | ||
| export const ACTOR_BASE_DOCKER_IMAGE_DEFAULT = 'apify/actor-node'; |
There was a problem hiding this comment.
Maybe we can remove this const too? We have no notion of "default base Docker image" anymore, and it's only used in two files in integration tests, where we can/should hardcode it anyway.
There was a problem hiding this comment.
Yeah, right, I see it's only used on tests and there it can be hardcoded for sure.
There was a problem hiding this comment.
Done, fixed in https://github.com/apify/apify-core/pull/10579
fnesveda
approved these changes
Apr 13, 2023
mtrunkat
changed the title
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is not currently used anywhere, and the repo with docker images should serve as a single source of truth.