-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the tests directory to PSR-4 autoloading #332
Conversation
Yup this is right. It builds on the other PR. If this gets merged/accepted I can close/drop the other one.
Thanks! I have rebased to resolve merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the refactoring! LGTM.
I think I found some issues with the legacy autoload code during the review, but this is definitely out of the scope of this review. I will address it with a PR, which will be helpful when we continue PSR-4 refactoring towards source
folder.
BTW this needs to be rebased again to be merged, sorry about this. |
Done. |
For details on composer autoload, see: https://getcomposer.org/doc/04-schema.md#autoload This helps move from a custom maintained autoload function to a standard one built by composer. Composer's autoload function is widely used by the larger PHP community and is well tested. To maintain backwards compatibility, Autoload.php is still included, but emits a warning. This helps moves the project towards adopting the community standard PSR-4 autoloading: https://www.php-fig.org/psr/psr-4/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done.
This is first step towards moving the package to a namespace and the composer PSR-4 autoloader. The "classmap" autoloader is no longer used for tests. As the tests are not part of the public API, this is backwards compatible. Uses the PhpCas namespace. Refs #188
This is first step towards moving the package to a namespace and the composer PSR-4 autoloader. The "classmap" autoloader is no longer used for tests.
As the tests are not part of the public API, this is backwards compatible.
Uses the PhpCas namespace.
Refs #188. Closes #331.