Add public SignOut method to CasAuthentication class #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, [Request Validation in ASP.NET](https://msdn.microsoft.com/en-us/library/hh882339(v=vs.110).aspx) kicks in upon receiving a single sign-out request from CAS due to the nature of its POSTed content (i.e. XML). This pull requests provides utility for developers to call `CasAuthentication.SignOut();` which will not only invoke `FormsAuthentication.SignOut` (as a native replacement to `ClearAuthCookies()`) but also clear the user's service ticket from cache, which is currently not being done.
|
The documentation you cited mentions HTML content specifically, but the payload of the single sign-out request is XML. Is XML specifically considered "potentially dangerous content," thus causing requests to be rejected? Just trying to follow your logic on the problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Request Validation in ASP.NET kicks in upon receiving a single sign-out request from CAS due to the nature of its POSTed content (i.e. XML).
This pull requests provides utility for developers to call
CasAuthentication.SignOut();which will not only invokeFormsAuthentication.SignOut(as a native replacement toClearAuthCookies()) but also clear the user's service ticket from cache, which is currently not being done.