Skip to content

Commit

Permalink
More accurate calculation of areafact in remapping (CICE-Consortium#849)
Browse files Browse the repository at this point in the history
* Modified doc to specify that l_fixed_area is T for C-grid

* Initial modifs to calc areafact based on linear interpolation of left and rigth values

* put back l_fixed_area = .true. for C-grid

* added temporary comments for PR review

* Modified areafac calc for case 1 and case 2

* Corrected minor compilation issues

* Corrected conditions for case 1 to make sure areas add up

* Small modif in l_fixed_area section to ensure only one condition is true

* Modified conditions in locate triangle to be consistent with previous changes for case 1

* Use other edge areafac_c for TL, BL, TR and BR triangles

* Some comments removed

* Fixed out of bounds areafac_ce and now use earea and narea

* Replaced ib,ie,jb,je in locate_triangle using ilo,ihi,jlo,jhi

* Modified areafac for TL1, BL2, TR1 and BR2 for area flux consistency

* Cosmetic changes

* Added comment to explain latest change

* Modification of bugcheck condition for l_fixed_area=T

* update areafac_c, areafac_ce in halo in dynamics

---------

Co-authored-by: apcraig <[email protected]>
  • Loading branch information
JFLemieux73 and apcraig authored Sep 15, 2023
1 parent 06282a5 commit 01ed4db
Show file tree
Hide file tree
Showing 3 changed files with 190 additions and 114 deletions.
Loading

0 comments on commit 01ed4db

Please sign in to comment.