Ability to place statement specific rules in rules sub directory #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronislav
force-pushed
the
statement-specific-rules
branch
from
75fd66b
to
1e25cf0
Compare
bronislav
changed the title
|
I updated the logic to keep the previous behavior and allow a new behavior (statement-specific rules in a subdirectory) at the same time. The main reason behind this change is that I don't want to rename statements after importing them if I realize that I need a statement-specific rules file. @apauley What do you think regarding this implementation or do you think that we need a runtime option to enable this behaviour |
bronislav
force-pushed
the
statement-specific-rules
branch
2 times, most recently
from
911d8bf
to
df21454
Compare
bronislav
force-pushed
the
statement-specific-rules
branch
from
df21454
to
bd1f000
Compare
|
Hi @bronislav - could you update the docs in the README so that it explains how we can make use of this? https://github.com/apauley/hledger-flow#statement-specific-rules-files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation for the #102. Obviously it can not be shipped as is as it is backward incompatible with current version.
I opened this pull request with the sole purpose to get feedback whether @apauley is open for such change or not. I'll add an additional cli flag to allow both behaviour to coexist if this is something you could consider to merge