ZOOKEEPER-2802:Zookeeper C client hang @wait_sync_completion #2102
+79
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not terminate the do_io thread immediately when the client in "unrecoverable" state, because it can not guarantee there is no new request gets in the work queue at the same time. The safer way is make do_io keep completing the new requests when the client is unrecoverable, until a close request gets in. Also, since we don't terminate do_io thread at SESSIONEXPIRED, remove the matching testcase from TestZookeeperClose.cc
yzx1983
force-pushed
the
master-fixclientdeadlock
branch
from
5502cea to
30f1591
Compare
|
This is my test code to reproduce the hung issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not terminate the do_io thread immediately when the client in "unrecoverable" state, because it can not guarantee there is no new request gets in the work queue at the same time. The safer way is make do_io keep completing the new requests when the client is unrecoverable, until a close request gets in.