WICKET-7066: Make type=module possible for JavascriptHeaderItem #598
Conversation
| @@ -16,7 +16,10 @@ | |||
| */ | |||
| package org.apache.wicket.markup.head; | |||
|
|
|||
| import static org.apache.wicket.markup.head.JavascriptReferenceType.*; | |||
|
|
||
| public enum JavascriptReferenceType { | ||
|
|
||
| TEXT_JAVASCRIPT("text/javascript"), MODULE("module"); |
There was a problem hiding this comment.
What about other types like importmap ?
Using an enum makes it hard to use custom values when/if needed.
There was a problem hiding this comment.
Hi Martin,
thank you for your remark.
I just started with the approach using a simple String instead of an Enum.
But then I realized, that there are only two "real" types for Javascript-References: Javascript-Mimetype ( "text/javascript", "application/javascript", "application/ecmascript") and "module".
All other types imply that the src-Attribute is ignored and the "real content" is placed inside the body of the <script>-Tag. But this is not the intention of the AbstractJavaScriptReferenceHeaderItem.
The documentation I used: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type
Kind regards
Hans
| */ | ||
| package org.apache.wicket.markup.head; | ||
|
|
||
| public enum JavascriptReferenceType { |
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
@hosea ping! :-) |
wicket-core/src/main/java/org/apache/wicket/markup/head/JavascriptReferenceType.java
Outdated
Show resolved
Hide resolved
No description provided.