THRIFT-5794 testcase #3000
Closed
THRIFT-5794 testcase #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jens-G
force-pushed
the
THRIFT-5794-tests
branch
2 times, most recently
from
fb4b6fd
to
d77b534
Compare
Closed
---- netstd: tests: also run tests with "net8" option of thrift-compiler Add a project which is a copy of the PublicInterfaces.Compile.Tests, but use the "net8" compiler option to generate code that uses C#12-features. Use the thrift-files from the existing test, to avoid code-duplication. This is effectively the tests that are run till v0.20.0. netstd: use default CSharp-language level of compiler instead of using Net8/C#12 for PublicInterfaces.Compile.Tests netstd: update readme for local building netstd: tests: include .exe extension, when looking for compiler It will not be found without this and causes na error and abort. netstd: tests: make MSBuild ignore errors when thrift-binary is not found and continue search Windows copmmand "where" errors when thrift-binary is not found in PATH. This will cause MSBuild to abort instead of searching in alternative paths. So just ignore potential erros and make it go on. Adapt this also for Unix "which", so we don't need to suppress the returncode.
Jens-G
force-pushed
the
THRIFT-5794-tests
branch
from
d77b534
to
64bb8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #2999:
netstd: tests: also run tests with "net8" option of thrift-compiler
Add a project which is a copy of the PublicInterfaces.Compile.Tests, but use the "net8" compiler option to generate code that uses C#12-features.
Use the thrift-files from the existing test, to avoid code-duplication.
This is effectively the tests that are run till v0.20.0.
netstd: use default CSharp-language level of compiler instead of using Net8/C#12 for PublicInterfaces.Compile.Tests
netstd: update readme for local building
netstd: tests: include .exe extension, when looking for compiler
It will not be found without this and causes na error and abort.
netstd: tests: make MSBuild ignore errors when thrift-binary is not found and continue search
Windows copmmand "where" errors when thrift-binary is not found in PATH. This will cause MSBuild to abort instead of searching in alternative paths.
So just ignore potential erros and make it go on. Adapt this also for Unix "which", so we don't need to suppress the returncode.