Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5794 netstd fix syntax error in deepcopy() method for v0.20.0 #2993

Closed
wants to merge 3 commits into from
Closed

THRIFT-5794 netstd fix syntax error in deepcopy() method for v0.20.0 #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08029e4
netstd: fix syntax error in deepcopy() method
SvenRoederer Jul 4, 2024
f7cda29
netstd: add test for deepcopy() syntax error
Jul 5, 2024
4f252f4
netstd: use default compiler settings for syntax test
SvenRoederer Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/generate/t_netstd_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ void t_netstd_generator::generate_netstd_deepcopy_method(ostream& out, t_struct*
out << endl << indent() << "{" << endl;
indent_up();
} else {
out << endl;
out << ";" << endl;
}

for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
Expand Down
1 change: 1 addition & 0 deletions .../Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift.PublicInterfaces.Compile.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial,net8 -r ./Thrift5253.thrift" />
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial,net8 -r ./Thrift5320.thrift" />
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial,net8 -r ./Thrift5382.thrift" />
<Exec Command="$(PathToThrift) -gen netstd -r ./git-pr2993.thrift" />
</Target>

</Project>
8 changes: 8 additions & 0 deletions lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/git-pr2993.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
namespace * deepcopy_syntax

struct CIELab
{
1: double L;
2: double a;
3: double b;
}