-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump com.ncorti.ktfmt.gradle from 0.12.0 to 0.13.0 in /lib/kotlin #2837
Bump com.ncorti.ktfmt.gradle from 0.12.0 to 0.13.0 in /lib/kotlin #2837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping this changes formatting very slightly. I can merge this, but then all the subsequent PRs will fail until the formatting is fixed. I don't have gradle set up to format right now, so I'll leave this merge to somebody else.
Bumps com.ncorti.ktfmt.gradle from 0.12.0 to 0.13.0. --- updated-dependencies: - dependency-name: com.ncorti.ktfmt.gradle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
960986b
to
2b3dbfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried applying the formatting changes, but I was not able to make progress, because of a bug in the plugin that was already reported at cortinico/ktfmt-gradle#181
I don't really know an easy workaround. Maybe @jimexist knows, but I'm inclined to leave the ktfmt plugin at 0.12.0 for now until the issue is fixed upstream.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
This applies trivial formatting requirements for ktfmt 0.13.0 from abandoned PR apache#2837, but does not bump ktfmt to 0.13.0, due to bugs in that version. These formatting improvements should be suitable for the current 0.12.0 version of ktfmt, but will avoid needing to re-apply these changes when ktfmt is eventually updated.
Bumps com.ncorti.ktfmt.gradle from 0.12.0 to 0.13.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)