Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite the endian conversion to fix a big-endian host #2754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rewrite the endian conversion to fix a big-endian host #2754

wants to merge 1 commit into from

Commits on Feb 6, 2023

  1. rewrite the endian conversion to fix a big-endian host 

    Client: py

Change htolell(dub) to htolell(transfer.t) in compact.h, because the
conversion takes a long long, not a double.  This matters on a
big-endian host, where the conversion must swap bytes.

The big-endian letohll(n) failed because ntohl(n) is just n, doesn't
swap n.  Rewrite ntohll(n) and letohll(n) to use the same code with
both big-endian and little-endian hosts.  Expect the compiler to
optimize away one of ntohll(n) or letohll(n) when it doesn't swap n.
    @kernigh
    kernigh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4e52b71 View commit details
    Browse the repository at this point in the history