Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Over-rendering on result table #30857

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

justinpark
Copy link
Member

SUMMARY

The issue of the grid table being over-rendered every time the tab is changed is caused by the mapping of orderedColumns. To prevent this over-rendering, this commit modified the code to use useMemo and React.memo, ensuring that the same properties from the previous tab are passed to avoid unnecessary re-renders.

TESTING INSTRUCTIONS

locally perf check

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Nov 6, 2024
@justinpark justinpark force-pushed the justin--hotfix-over-rendering-on-result-table branch from 6c6f35f to 6f5acad Compare November 6, 2024 16:58
@justinpark justinpark force-pushed the justin--hotfix-over-rendering-on-result-table branch from 59953bf to dd20be5 Compare November 6, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants