fix: Graph chart colors #30851
Merged
fix: Graph chart colors #30851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v4.1
justinpark
reviewed
Nov 8, 2024
superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts
Outdated
Show resolved
Hide resolved
villebro
reviewed
Nov 8, 2024
superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts
Outdated
Show resolved
Hide resolved
michael-s-molina
force-pushed
the
fix-graph-colors
branch
from
3628921
to
fc2018b
Compare
villebro
reviewed
Nov 8, 2024
superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts
Outdated
Show resolved
Hide resolved
villebro
approved these changes
Nov 11, 2024
sadpandajoe
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 0e165c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the Graph chart to obey to the color scheme when there are no color categories.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-11-06.at.09.32.35.mov
Screen.Recording.2024-11-06.at.09.36.48.mov
TESTING INSTRUCTIONS
1 - Check that the color scheme is applied when there are no color categories.
2 - Check that the color scheme is applied when there are color categories.
ADDITIONAL INFORMATION