Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Add Conditional Scroll prevention. #30837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Srayash
Copy link

@Srayash Srayash commented Nov 4, 2024

SUMMARY

Fixes #30756
Added conditional Scroll prevention to avoid unwanted scrolling.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:Scroll to top on Tab click #30756
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard Namespace | Anything related to the Dashboard label Nov 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sadpandajoe sadpandajoe changed the title fix!(dashboard): Add Conditional Scroll prevention. fix(dashboard): Add Conditional Scroll prevention. Nov 5, 2024
@sadpandajoe
Copy link
Member

@Srayash thanks for your first PR. Quick question, does your change still work with tabbing? The original change was for this feature: #26138 so we want to make sure there isn't a regression with this change.

@Srayash
Copy link
Author

Srayash commented Nov 5, 2024

Hi @sadpandajoe, thanks for the question and the review! This change is intended to be compatible with the original tabbing behavior from #26138. Please let me know if there’s anything specific you’d like me to focus on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Namespace | Anything related to the Dashboard size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll to top on Tab click
2 participants