Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): not filterable column now not emitting cross-filters in table charts #30827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HaroldWrenFinch
Copy link

SUMMARY

Only columns which are filterable emitting filters, which is very handyful when you are using <a href-s in a calculated column, and you don't want the click to emit filter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. In the datasets you can turn off "is filterable" column by editing the dataset and turning off the column checkbox. ex.:
    1. in video_game_sales dataset you can turn off the name column "is filterable" checkbox
  2. Then in the corresponding dashboard you can check it by clicking the column data in the table chart and it will not filtering the data. ex.:
    1. video game sales dashboard
    2. explore trends tab
    3. games table chart
    4. click any value in the name column

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard:cross-filters Related to the Dashboard cross filters label Nov 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina changed the title fixed(dashboard): not filterable column now not emitting cross-filters in table charts fix(dashboard): not filterable column now not emitting cross-filters in table charts Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:cross-filters Related to the Dashboard cross filters plugins size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant