Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(embedded): Embed Charts using GuestToken similar to SIP-75 #30076

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(embedded): Embed Charts using GuestToken similar to SIP-75 #30076

wants to merge 2 commits into from

Conversation

jayakrishnankk
Copy link
Contributor

SUMMARY

Associated SIP -> #30075

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TODO

TESTING INSTRUCTIONS

Ensure EMBEDDED_SUPERSET is enabled in the config.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-145] Proposal for Embeddable Charts using the same mechanism as #17187 #30075
  • Required feature flags: EMBEDDED_SUPERSET=True
  • Changes UI: Adds a menu option in the Explore view of the chart to embed chart
  • Includes DB Migration (follow approval process in SIP-59)
    • [?] Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added risk:db-migration PRs that require a DB migration api Related to the REST API labels Aug 30, 2024
@rusackas rusackas mentioned this pull request Sep 10, 2024
Closed
jayakrishnankk
jayakrishnankk commented Oct 16, 2024
View reviewed changes
superset-frontend/src/embedded/index.tsx
);

const EmbeddedRoute = () =>
bootstrapData.embedded!.dashboard_id ? (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be bootstrapData.embedded ? (
Needs a fix.

@eschutho
Copy link
Member

Hi @jayakrishnankk, thank you for this PR! Is there any support we can give you on this PR draft? Are you needed some initial feedback on the approach before moving forward?

@rusackas
Copy link
Member

Noting here that the SIP Vote currently has 2 binding and 2 non-binding positive votes. If you haven't voted already, please do! @eschutho your vote can help get this over the line, if you like the proposal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch will be requested when the pull request is marked ready for review mistercrunch is a code owner

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina michael-s-molina will be requested when the pull request is marked ready for review michael-s-molina is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida will be requested when the pull request is marked ready for review betodealmeida is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho will be requested when the pull request is marked ready for review eschutho is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api Related to the REST API review:draft risk:db-migration PRs that require a DB migration size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jayakrishnankk @eschutho @rusackas @michael-s-molina @jayakrishnankarolilnlsn