Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations): Fix the time comparison migration #30029

Merged
merged 4 commits into from
Aug 27, 2024
Merged

fix(migrations): Fix the time comparison migration #30029

merged 4 commits into from
Aug 27, 2024
+75 −157

Commits on Aug 27, 2024

  1. - FIx time comparison migration so charts that are not using comparis… 

    …on can be upgraded properly

- Add extra tests to cover or new cases
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c89ed4e View commit details
    Browse the repository at this point in the history

  2. - time_compare is an array not a string in the new version of the con… 

    …trols
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    46c2af4 View commit details
    Browse the repository at this point in the history

  3. - Address comments on test readability by extracting common params

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6af8275 View commit details
    Browse the repository at this point in the history

  4. - Add typing to fix mypy errors

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e349e28 View commit details
    Browse the repository at this point in the history