Skip to content

Commit

Permalink
remove commented out code, document toggle comments
Browse files Browse the repository at this point in the history
  • Loading branch information
dvchristianbors committed Feb 21, 2024
1 parent d5ce5d6 commit b991917
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions superset/common/query_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,8 @@ def validate(
self._validate_no_have_duplicate_labels()
# problematic line where calling sqlparser.parse() causes quadratic
# performance for WHERE ... IN (...) clauses
# Clauses are anyway checked for their validity in
# e.g., connectors/sqla/models/get_query_str_extended
# self._sanitize_filters()
return None
except QueryObjectValidationError as ex:
Expand Down
2 changes: 1 addition & 1 deletion superset/models/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ def get_df( # pylint: disable=too-many-locals
mutator: Callable[[pd.DataFrame], None] | None = None,
) -> pd.DataFrame:
# before we split sqls using sql parse, however this core code is only reachable
# with single sql queries. Thus, we removed the engine spec parser
# with single sql queries. Thus, we remove the engine spec parser here
# sqls = self.db_engine_spec.parse_sql(sql)

with self.get_sqla_engine_with_context(schema) as engine:
Expand Down

0 comments on commit b991917

Please sign in to comment.