[BREAKING CHANGE] Simplified the release process #12903
Merged
+38
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
reviewed
Dec 27, 2024
docs/en/guides/How-to-release.md
Outdated
| @@ -79,18 +45,18 @@ git push origin v${RELEASE_VERSION} | |||
| ## Stage the release | |||
|
|
|||
| ```bash | |||
| ./mvnw flatten:flatten install deploy -DskipTests | |||
| ./mvnw package -DskipTests | |||
There was a problem hiding this comment.
install might be still needed if the version is not installed before?
| ``` | ||
|
|
||
| This command will build, sign, and deploy the release to the Apache staging repository. | ||
| You should be prompted for your GPG passphrase during the deployment process. | ||
| If no prompt is present, you can set the passphrase in the environment variable `MAVEN_GPG_PASSPHRASE`: | ||
|
|
||
| ```bash | ||
| MAVEN_GPG_PASSPHRASE=<your-gpg-passphrase> ./mvnw flatten:flatten install deploy -DskipTests |
There was a problem hiding this comment.
GPG related is not needed anymore, it was for maven verification. Now we will only sign the final tar.
Fine0830
previously approved these changes
Dec 27, 2024
kezhenxu94
reviewed
Dec 27, 2024
| @@ -75,5 +75,7 @@ tar czf ${PRODUCT_NAME}-src.tgz \ | |||
| ${PRODUCT_NAME} | |||
|
|
|||
| gpg --armor --detach-sig ${PRODUCT_NAME}-src.tgz | |||
| gpg --armor --detach-sig ${PRODUCT_NAME}.tgz | |||
There was a problem hiding this comment.
The file name is create_source_release.sh, but these two lines are signing binary package, what do you think moving these two lines to the release doc or renaming this script file?
There was a problem hiding this comment.
I prefer rename the script file.
There was a problem hiding this comment.
@kezhenxu94 I updated the docs a little bit more, to move binary into releasing folder.
kezhenxu94
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.skywalking-oap-serverare no longer published through maven central. We will onlypublish the source tar and binary tar to the website download page, and docker images to docker hub.
skywalking-oap-serveras a dependency in your project, you need to download thesource tar from the website and publish them to your private maven repository.
FYI @apache/skywalking-committers please notice this new proposal. I am not sure who are using these dependencies, but truly, we are not expecting this.