Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot query zipkin traces with annotationQuery parameter in the JDBC related storage #11511

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix cannot query zipkin traces with annotationQuery parameter in the JDBC related storage #11511

merged 1 commit into from
Nov 8, 2023

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Nov 8, 2023

When I use JDBC-related storage, such as PostgreSQL, and execute /zipkin/api/v2/traces?annotationQuery=error with zipkin-query plugin, it prompts an SQL error.

1681699414761_ pic

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@mrproliu mrproliu added the bug Something isn't working and you are sure it's a bug! label Nov 8, 2023
@mrproliu mrproliu added this to the 9.7.0 milestone Nov 8, 2023
@mrproliu mrproliu requested a review from wankai123 November 8, 2023 05:32
@wu-sheng wu-sheng added backend OAP backend related. tracing Distributed tracing zipkin labels Nov 8, 2023
@wu-sheng wu-sheng merged commit 7b01a4a into apache:master Nov 8, 2023
167 checks passed
@mrproliu mrproliu deleted the jdbc-zipkin-query branch November 8, 2023 07:07
@mrproliu mrproliu mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wankai123 wankai123 wankai123 approved these changes

Assignees
No one assigned
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug! tracing Distributed tracing zipkin
Projects
None yet
Milestone
9.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrproliu @wankai123 @wu-sheng