Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-672] Bug fix for ST_LengthSpheroid #1679

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

furqaankhan
Copy link
Contributor

@furqaankhan furqaankhan commented Nov 7, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

ST_LengthSpheroid didn't consider Polygons with holes (interior rings). This bug fix addresses that issue.
Eg:

WKT:


POLYGON((-122.33 47.61, -122.32 47.62, -122.31 47.61, -122.30 47.62, -122.29 47.61, -122.30 47.60, -122.31 47.59, -122.32 47.60, -122.33 47.61), (-122.315 47.605, -122.305 47.615, -122.295 47.605, -122.305 47.595, -122.315 47.605))

old output:                   17363.913692009628

output after changes: 16106.506409488933

How was this patch tested?

  • Passed CI

Did this PR include necessary documentation updates?

  • No, behavior stays the same for this function.

@furqaankhan furqaankhan changed the title fix: bug fix for ST_LengthSpheroid [SEDONA-672] Bug fix for ST_LengthSpheroid Nov 7, 2024
@jiayuasu jiayuasu added this to the sedona-1.7.0 milestone Nov 7, 2024
@furqaankhan furqaankhan marked this pull request as ready for review November 7, 2024 18:49
@jiayuasu jiayuasu added the bug label Nov 8, 2024
@jiayuasu jiayuasu merged commit f8bc4d3 into apache:master Nov 8, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants