Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-659] Upgrade JTS version to 1.20.0 #1655

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

Kontinuation
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Upgrade JTS from 1.19.0 to 1.20.0.

Most of the changes are made to the tests due to different computation results obtained from 1.20.0. The following functions are affected from the observations of broken tests:

  • ST_MaximumIncribedCircle
  • ST_VoronoiPolygons
  • ST_TriangulatePolygon
  • ST_Buffer
  • ST_ConcaveHull

ST_MaximumIncribedCircle has significant changes, while other functions only introduce slight coordinate value changes.

How was this patch tested?

Passing tests.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@Kontinuation
Copy link
Member Author

PR for running snowflake tests: wherobots#38

@Kontinuation Kontinuation marked this pull request as ready for review October 25, 2024 09:36
@jiayuasu jiayuasu added this to the sedona-1.7.0 milestone Oct 25, 2024
@jiayuasu jiayuasu merged commit 3a73733 into apache:master Oct 25, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants