[SEDONA-102] Use spotless as Java and Scala code formatter #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
sedona-flink
sedona-common
sedona-spark
sedona-snowflake
root
labels
Kontinuation
changed the title
|
Let's put a hold on this. A big batch of ST functions will be cherry picked from Wherobots to Apache Sedona next week 😁 |
Have we finished cherry-picking ST functions? Is it OK to enable spotless for now? |
|
Yes, it's all done. Let's enable Spotless @Kontinuation |
Kontinuation
force-pushed
the
spotless
branch
2 times, most recently
from
00ee2a3
to
54d3529
Compare
github-actions
bot
removed
sedona-flink
sedona-common
sedona-spark
sedona-snowflake
labels
github-actions
bot
added
sedona-flink
sedona-common
sedona-spark
sedona-snowflake
labels
jiayuasu
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Use spotless to format Java and Scala code. Format is checked when running
mvn compile, code can be automatically formatted by runningmvn spotless:applycommand.How was this patch tested?
Passing existing tests.
Did this PR include necessary documentation updates?
mvn spotless:applystep to the contribution rule.