Fix throwing deserialization exceptions for SnapshotIndexBlobs #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
BlobStoreUtil
'sgetSnapshotIndex
method currently gets theSnapshotIndex
blob usingBlobStoreManager#get
and deserializes it usingSnapshotIndexSerde
We chain the deserialization logic to the get future and in turn chain
handle
to the deserialization future which tries to capture deserialization exceptions. This is incorrect as any exceptions that occurred during snapshot index get would also be processed by the chainedhandle
.This presents two issues:
SamzaException
class.get
implementation ofBlobStoreManager
classifies some exceptions into retriable exceptions which will become useless if we wrap it intoSamzaException
.Changes:
thenApplyAsync
where we deserialize theSnapshotIndex
bytes.Tests:
API Changes:
None
Upgrade Instructions:
None
Usage Instructions:
None