[RATIS-2082] RaftPeers equal should also check address #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @codings-dan @szetszwo |
szetszwo
reviewed
May 9, 2024
|
I think https://issues.apache.org/jira/browse/RATIS-1860 meets the same issue and can fix the issue by ratis-shell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have two raft cluster,
A cluster IP is
A1:7082,A2:7082,A3:7082
B cluster master ip is
B1:7082,B2:7082,B3:7082
When we start A cluster we use a wrong config
A1:7082,A2:7082,B3:7082
After we start the cluster we found we use wrong config.
But this info has been write to raft-meta.conf.
Then after we restart A cluster, when client connect to A cluster.
It connect to A cluster follower then return the cached leader address, the leader peer id is 3, but in the meta conf, the peer rpc link is B3:7082.
Then cause it connect to cluster B.
Its caused by RaftPeer object equal only compare peerId cause it won't refresh raft-meta.conf
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2082
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)