Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added missing fields on TopicStats #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jffp113
Copy link
Contributor

@jffp113 jffp113 commented Nov 21, 2023

Motivation

When using the admin api with golang there is some missing fields on topic stats:
https://pulsar.apache.org/docs/next/admin-api-topics/#get-stats

Modifications

Added missing fields on topic stats

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: yes
  • The schema: yes
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? PulsarDoc
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to verify that it could get these stats correctly?

@geniusjoe
Copy link
Contributor

I think we need to add GetPartitionedStats and GetPartitionedStatsWithOption interface test cases in topic_test.go. Since make test command will automatically deploy a pulsar broker in test period, it is quite easy to write test cases. And we can refer TestPartitionStats test case in the latest default branch.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants