fix build error #2644
Open
fix build error #2644
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Experimental Bot, please feedback here] NuttX PR Requirements ReviewMeets Requirements? Partially Summary: While the PR addresses a real issue (#2632), the summary section lacks crucial details:
Impact:
Testing:
Recommendation: Expand the Summary and Impact sections with the missing information. Provide detailed testing logs to showcase the change's effectiveness. |
examples/nettest/nettest_server.c
Outdated
| #ifdef __APPLE__ | ||
| acceptsd = accept(listensd, (struct sockaddr *)&myaddr, &addrlen); | ||
| #else | ||
| #if !defined(__APPLE__) && defined(__NuttX__) |
There was a problem hiding this comment.
Suggested change
| #if !defined(__APPLE__) && defined(__NuttX__) | |
| #ifdef __NuttX__ |
| #ifdef __APPLE__ | ||
| acceptsd = accept(listensd, (FAR struct sockaddr *)&myaddr, &addrlen); | ||
| #else | ||
| #if !defined(__APPLE__) && defined(__NuttX__) |
There was a problem hiding this comment.
Suggested change
| #if !defined(__APPLE__) && defined(__NuttX__) | |
| #ifdef __NuttX__ |
[linguini@pastabox nuttx]$ make -j
CC: tcpblaster_server.c
LN: platform/board to
/home/linguini/cuinspace/pico-nuttx/apps/platform/dummy
tcpblaster_server.c: In function ‘tcpblaster_server’:
tcpblaster_server.c:159:14: error: implicit declaration of function
‘accept4’; did you mean ‘accept’? [-Wimplicit-function-declaration]
159 | acceptsd = accept4(listensd, (FAR struct sockaddr *)&myaddr,
&addrlen,
| ^~~~~~~
| accept
make[3]: *** [Makefile:92: tcpblaster_server.hobj] Error 1
make[2]: *** [Makefile:53:
/home/linguini/cuinspace/pico-nuttx/apps/examples/tcpblaster_context]
Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:180: context] Error 2
make: *** [tools/Unix.mk:457:
/home/linguini/cuinspace/pico-nuttx/apps/.context] Error 2
make: *** Waiting for unfinished jobs....
from apache#2632
Signed-off-by: wanggang26 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[linguini@pastabox nuttx]$ make -j
CC: tcpblaster_server.c
LN: platform/board to
/home/linguini/cuinspace/pico-nuttx/apps/platform/dummy tcpblaster_server.c: In function ‘tcpblaster_server’: tcpblaster_server.c:159:14: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Wimplicit-function-declaration]
159 | acceptsd = accept4(listensd, (FAR struct sockaddr *)&myaddr,
&addrlen,
| ^~~~~~~
| accept
make[3]: *** [Makefile:92: tcpblaster_server.hobj] Error 1
make[2]: *** [Makefile:53:
/home/linguini/cuinspace/pico-nuttx/apps/examples/tcpblaster_context]
Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:180: context] Error 2
make: *** [tools/Unix.mk:457:
/home/linguini/cuinspace/pico-nuttx/apps/.context] Error 2
make: *** Waiting for unfinished jobs....
Impact
from #2632
Testing
CI TEST