system/composite_main.c: Hide fprintf behind macro to handle FILE_STR… #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFIG_FILE_STREAMS now defaults to 'n' when DEFAULT_SMALL is enabled. This is a good change, but this source file fails to compile when file streams are disabled. Fix this by using dprintf.
pussuw
force-pushed
the
composite_main_fprintf_fix
branch
from
ea809cf
to
bd5e68e
Compare
pkarashchenko
approved these changes
Mar 31, 2023
xiaoxiang781216
approved these changes
Apr 1, 2023
pkarashchenko
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…EAMS=n
Summary
CONFIG_FILE_STREAMS now defaults to 'n' when DEFAULT_SMALL is enabled. This is a good change, but this source file fails to compile when file streams are disabled.
Fix this by using fprintf / dprintf depending on the config value.
Impact
Fixes build error when DEFAULT_SMALL used
Testing
Out-of-tree target with:
CONFIG_DEFAULT_SMALL=y
...
CONFIG_USBDEV=y
CONFIG_USBDEV_COMPOSITE=y