NUTCH-2481 HostDatum deltas(previous step statistics) and Metadata expressions #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…both (strng,number) and (string, string) pairs
…config. Now the format of the return key can be either Number of String
YossiTamari
reviewed
Jan 29, 2018
| // Create or retrieve a JexlEngine | ||
| JexlEngine jexl = new JexlEngine(); | ||
|
|
||
| // Dont't be silent and be strict |
There was a problem hiding this comment.
Dont't must be a typo, but beyond that, setSilent(true) seems to contradict this comment.
There was a problem hiding this comment.
@YossiTamari
The funny part it is a copy-paste from ReadHostDb line 83.
How do you propose to fix it?
There was a problem hiding this comment.
I'm not sure what the original intent was, but maybe we should replace this whole code (in both places) with:
this.deltaExpression = org.apache.nutch.util.JexlUtil.parseExpression(stringDeltaExpression);?
|
@YossiTamari |
lewismc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of updatehostdb is changed slightly.
In case of specification of hostdb.deltaExpression, we dont reset statistics in mapper, but send the previous step statistic first to the reducer and reset it afterwards.
In line 215 of the mapper
if (readingCrawlDb)
is replaced by
if (readingCrawlDb && !isDeltaStatisticCalculated) {
hostDatum.resetStatistics();
Please, verify that logic doesn't break the current functionality.