update formatter to handle record closing braces correctly. solves #7043 #8101
+199
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition adds tests to show the error adds inner and outer record in ui template text for setting java format spaces solves the error by moving spaces(cs.spaceWithinMethodDeclParens() ? 1 : 0, true); to the correct place. solves apache#7043 formatter to handle record closing braces correctly squashed commits of test and solution.
homberghp
changed the title
mbien
added
Java
|
@homberghp I moved the new test back into If you are ok with this I would like to squash it with your changes and create a new PR. Usually I would ask to push into the PR branch but you used master directly - I don't want to break your clone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #7043
Effectively moved one line, that corrects the record closing brace error.
The line
has been removed in one spot and added in another.
Added tests to validate correct formatting.
Added record code to template text for the editor>formatting>java/spaces form.
I have no clue how the change in line 950 happened, but is white space only.
Editing in the source code done with netbeans 24 or ubuntu 24.04