Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show splash screen on mouse current Display #8045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dyorgio
Copy link
Contributor

@dyorgio dyorgio commented Dec 12, 2024

Use PointerInfo class to get current mouse Display and pass it to Frame constructor. Fallback to default Display in case of no PointerInfo (someone without mouse).

Use PointerInfo class to get current mouse Display and pass it to Frame constructor. Fallback to default Display in case of no PointerInfo (someone without mouse).
@dyorgio dyorgio marked this pull request as ready for review December 12, 2024 20:53
@dyorgio
Copy link
Contributor Author

dyorgio commented Dec 12, 2024

I tried to labeling it, but I don't have permission I guess...
Ideally all dialogs (like Preferences, about, and others) could appears on same mouse Display.

@mbien mbien added Platform [ci] enable platform tests (platform/*) UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 13, 2024
@mbien
Copy link
Member

mbien commented Dec 13, 2024

not sure about this tbh. The config import dialog, splash and main window will all show up on the default screen right now.

The main window (and all detached views) can be moved around and will remember the position for subsequent starts. So at least the first launch is consistent. I think it would be confusing to show the splash on a secondary screen just because the mouse happens to be there, while everything else would show up on the default screen still.

@dyorgio
Copy link
Contributor Author

dyorgio commented Dec 13, 2024

I agree, this kind of modification needs to be consistent system wide.

Today I open dialogs with focus on secondary display and they open is primary (like preferences and some others)…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants