Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrast fix for main cards #591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Eccenux
Copy link

@Eccenux Eccenux commented Mar 7, 2022

There is a very low contrast on the main page on the green card (below 2). The other cards is about 5 and 8 so acceptable. A simple fix is to change color of the text to black as in the patch.

Another option is to use darker green. But would need to be at least #809D2A to to be viable for large text and #667D21 for small text.

@Eccenux
Copy link
Author

Eccenux commented Mar 7, 2022

Oh. You can easily check contrast in Firefox dev tools (click on color: prop) or on WebAIM website:
https://webaim.org/resources/contrastchecker/

@neilcsmith-net
Copy link
Member

Thanks for looking at this. It's a very valid point. Not sure which is the right option. Will try and take a look shortly if no-one else steps in first.

@Chris2011
Copy link

Unfortunately I didn't take any notice of it until now where I go through my github stuff. Is this still relevant? Is this still the repo of the website?

@ebarboni
Copy link
Contributor

ebarboni commented Apr 4, 2024

@Chris2011 no this repos is "deprecated" for the site UI but the constrat concern are still valid.

https://github.com/apache/netbeans-antora-ui is the home of the related ui for the site

@Chris2011
Copy link

@ebarboni thx, will have a look there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants