hw/drivers/bme280: Fix writes to I2C #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasjer
force-pushed
the
kasjer/bme280-i2c-fix
branch
from
3e665f0
to
f1b4d88
Compare
|
That fixes my problem with bme280 and i2c. |
|
repos/apache-mynewt-core/hw/drivers/sensors/bme280/src/bme280.c:903:13: error: unused variable 'buf' [-Werror=unused-variable] Fix move the definition inside the #if MYNEWT_VAL(BUS_DRIVER_PRESENT) |
I2C writes when driver was enabled clear MSB of register address. This prevented any write to control registers. Now registers MSB is cleared on write only for SPI. Writing registers also requires single start condition. Code was doing write with restart condtion that does not seem to work correctly Signed-off-by: Jerzy Kasenberg <[email protected]>
kasjer
force-pushed
the
kasjer/bme280-i2c-fix
branch
from
f1b4d88
to
32d7b75
Compare
sjanc
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I2C writes when driver was enabled clear MSB of register address.
This prevented any write to control registers.
Now registers MSB is cleared on write only for SPI.