-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Blues Wireless note-c library support and example application. #3300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ujur007 If you change first commit to just pkg.yml with repository description checks for license and style from blue-c will not be done.
Then only application code will need to adhere to mynewt coding style before it can be merged.
d8081cb
to
8a133b2
Compare
f973dc1
to
18396bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting issues that somehow were not detected by automatic style checker.
have pushed the updated code. |
@ujur007 single empty lines are fine if they make code more readable. |
Ok. Updated the code. |
@ujur007 I wrote |
Okay now? |
Check details of |
There was extra space I think for that it has failed. Out of three files, two were ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your support. My first PR. |
Hi,
I have added support for Blues Wireless note-c library. in
/net/cellular
. Also, I have added an example application inside apps/blues-wireless to get location data based on GPS.I took the inspiration from note-zephyr repository.