Moved the RandomizedTesting generators to a separate library (Closes #257) #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing.Generators to 2.7.8-beta-0001
…l in favor of using RandomizedTesting.Generators
…the methods into LuceneTestCase
…ed all files related to randomizedtesting
…ers, added aggressive inlining, added documentation
…se RandomizedTesting.Generators. Also changed incorrect references to NextDouble() to use NextGaussian() where appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257.
This adds a reference to
RandomizedTesting.Generatorsand eliminates allRandomizedTestingcode from the test framework.Note that some of the random methods were originally part of Lucene, but having methods that can generate random unicode strings is probably something that we will often need without a dependency on the test framework. The
TestUtilmethod signatures were left intact (aside from parameter names), but they now just cascade the call toRandomizedTesting.Generators.